6 Mar
2020
6 Mar
'20
3:53 a.m.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39237/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/5/src/mainboard/google/dedede... PS5, Line 101: NATIVE What is NATIVE pad termination config mean? With that alone, SD Card is not getting detected by the OS. I need to set the UPD SdCardGpioCmdPadTermination = 0x1f to get SD Card detected on both boot and Hot Plug.
--
To view, visit https://review.coreboot.org/c/coreboot/+/39237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c8ceb85ada23718ff7b6fd7013317c818dd532
Gerrit-Change-Number: 39237
Gerrit-PatchSet: 5
Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aamir Bohra aamir.bohra@intel.com
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 03:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment