Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27542 )
Change subject: mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2#
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/27542/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nautilus/gpio.c:
https://review.coreboot.org/#/c/27542/1/src/mainboard/google/poppy/variants/...
PS1, Line 223:
They have 10k external pull-up. Components R672 and R642 in schematics.
Ah yes.. Thanks!
--
To view, visit
https://review.coreboot.org/27542
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I159f686cef9c8d254f390d7f1dff8011f43fc066
Gerrit-Change-Number: 27542
Gerrit-PatchSet: 1
Gerrit-Owner: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Jul 2018 06:39:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes