Attention is currently required from: Joel Linn, Matt DeVillier.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge) ......................................................................
Patch Set 3:
(4 comments)
File Documentation/mainboard/hp/pro_3500_series.md:
https://review.coreboot.org/c/coreboot/+/81368/comment/3d107c60_2ce101ca : PS3, Line 17: eval_rst Should be `{eval-rst}` after commit 35599f9a66 (Docs: Replace Recommonmark with MyST Parser)
https://review.coreboot.org/c/coreboot/+/81368/comment/8fb6ecb4_42d23bdb : PS3, Line 85: eval_rst `{eval-rst}`
https://review.coreboot.org/c/coreboot/+/81368/comment/39c4b8c2_7a672293 : PS3, Line 93: E Remove "E" after "IT". I.e. IT8779E not ITE8779E
File src/mainboard/hp/pro_3500_series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81368/comment/4f22b5c1_10de2e38 : PS3, Line 50: subsystemid 0x103c 0x2abf Can remove, already covered by the `subsystemid 0x103c 0x2abf inherit` earlier