Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35888 )
Change subject: src/arch/x86/smbios.c: add SMBIOS type 16 structure ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35888/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/35888/2/src/arch/x86/smbios.c@530 PS2, Line 530: int __weak fill_mainboard_smbios_type16(unsigned long *current, int *handle) that might collide with the type16 installed by some north-bridges. Not the case on APU2, but as soon as it is in place. How do you plan to prevent a duplicated entry on those boards/future boards?