Attention is currently required from: Raul Rangel, Furquan Shaikh, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46483 )
Change subject: program_loading: Replace prog_rdev() with raw start pointer and size
......................................................................
Patch Set 21:
(1 comment)
File src/include/program_loading.h:
https://review.coreboot.org/c/coreboot/+/46483/comment/73617ff6_b0d6795c
PS21, Line 49: void (*entry)(void *); /* Function pointer to entry point. */
function definition argument 'void *' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7c0f1c5698fa0c326e23c553ea0fe928b25d202
Gerrit-Change-Number: 46483
Gerrit-PatchSet: 21
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 17 Feb 2021 11:51:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment