Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 49:
(32 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/aed581c1_588857fd PS49, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/5d6bb8f5_cc327ae9 PS49, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/ce32e8d4_db064a1f PS49, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/fd21455d_9c074b68 PS49, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/c72c9676_42506769 PS49, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/5a2db9ba_29b30262 PS49, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/230d3835_0c0492f0 PS49, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/ea3eeacb_f5cd2f05 PS49, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/7c8c503f_c267a23e PS49, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/76eefc9a_66fab5aa PS49, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/bb345721_d871bf62 PS49, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/5aecdb0e_2cb87f59 PS49, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/aad2f205_f5769b8f PS49, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/1a1830db_043efce6 PS49, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/c7b6d173_9cce5369 PS49, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/d8375284_a2bb73f9 PS49, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/761b2fd0_9e1712d1 PS49, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/51d52db6_85d73515 PS49, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/c7bc0fd5_db865d24 PS49, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/979da98e_5153f5d6 PS49, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/bb0f63c6_b37b7e73 PS49, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/fa0a52df_74dd3f43 PS49, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/d28bb932_b48d9ebc PS49, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/e51566ee_b8379ffe PS49, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/eeb720f5_29880817 PS49, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/084cc850_7daf6688 PS49, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/9bccb53d_0f4cb30b PS49, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/7c0a97be_4f1a6822 PS49, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/74da22ee_b8570161 PS49, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/dd72cdfe_8747d9de PS49, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/8a69ec0c_90e76faa PS49, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159841): https://review.coreboot.org/c/coreboot/+/23586/comment/9b50c73d_ef97aab9 PS49, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const