Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63602 )
Change subject: cpu/x86/smm: Use struct region to check overlapping sections ......................................................................
Patch Set 20:
(2 comments)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/63602/comment/db510582_1e0bf30d PS19, Line 376: static unsigned int region_counter = 0;
A bit of asymmetry here, counter is in .bss while the list is on stack. […]
Done
https://review.coreboot.org/c/coreboot/+/63602/comment/61303c45_9097e653 PS19, Line 428: struct region region_list[SMM_REGIONS_ARRAY_SIZE] = {};
If this blows the stack requirements for APs too, maybe put this in .bss instead?
Done. Also added a comment to move it back to the stack once AP stacks are not a continuous region with BSP stack (CPU_INFO_V2 allows for that).