Attention is currently required from: Patrick Rudolph. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52797 )
Change subject: ec: Add Star Labs ITE 8987E support ......................................................................
Patch Set 7:
(1 comment)
File src/ec/starlabs/it8987/ec.h:
https://review.coreboot.org/c/coreboot/+/52797/comment/4d42b72e_d55c6702 PS6, Line 11: 0x4e
shouldn't that be provided by mainboard code as it could be 0x2e as well?
The datasheet for the IT8987 does allow 0x2e/0x2f and 0x4e/0x4f as address/data register pairs.
The working setting is controlled through the BADRSEL register which is only accessible from the EC domain and therefore is controlled by the binary blob EC firmware. All existing versions of the EC firmware use 0x4e/0x4f.