Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37402 )
Change subject: amdblocks/acpimmio: Unify BIOSRAM usage
......................................................................
Patch Set 7:
I don't see the changes done to hudson and sb800 as working, as I don't see a change in their makefile.inc to use the common code. IIRC, you're only getting away with it because Kyosti disabled the build of several old AMD platforms, hudson and sb800 included...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69a03e4f01d7fb2ffc9f8b5af73d7e4e7ec027da
Gerrit-Change-Number: 37402
Gerrit-PatchSet: 7
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Dec 2019 18:04:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment