Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86184?usp=email )
Change subject: mb/starlabs/*: Correct the enable GPIO for WLAN ......................................................................
mb/starlabs/*: Correct the enable GPIO for WLAN
These are configured incorrectly, to use the WLAN WAKE GPIOs as enable GPIOS. Correct these to use WIFI RF KILL, and disconnect the now unused WLAN WAKE GPIOs.
Change-Id: I12797875acacc231e155ab4e427a950a3b1b9703 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86184 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 10 files changed, 10 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 6353d64..5e9ca3f 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -223,7 +223,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: Test Point 10 */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 9c19348..341ea40 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -162,7 +162,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index dae0df2..ec32e83 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -222,7 +222,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb index d9892c5..af9e30e 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb @@ -170,7 +170,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "1" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index ed759d4..79a4c4c 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -222,7 +222,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index cc31831..abc4a7a 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -199,7 +199,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "skip_on_off_support" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 4ef11d4..a17c00f 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -222,7 +222,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_CFG_GPO(GPP_D14, 1, PLTRST), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index 5dfba49..db31d8d 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -205,7 +205,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index b0fb7cd..23ca3e5 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -227,7 +227,7 @@ /* D12: ES8336_INT_N */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_CFG_GPO(GPP_D14, 1, PLTRST), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 7c614fa..2ee5c67 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -221,7 +221,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: ALS Interrupt */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */