Attention is currently required from: Tarun Tuli, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69613 )
Change subject: soc/intel/meteorlake: transition full control over PM Timer from FSP to coreboot
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS2:
can you please rebase this CL on top of https://review.coreboot. […]
Ack
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/69613/comment/d37a4960_1ef5adea
PS1, Line 362: s_cfg->EnableTcoTimer = 1;
NOTE: This will have huge power impact when it's enabled. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2693f0390e6c9fa92fec366ab87589c3bcea9027
Gerrit-Change-Number: 69613
Gerrit-PatchSet: 4
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 09:13:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment