Hello build bot (Jenkins), Furquan Shaikh, Stefan Reinauer, Tim Wawrzynczak, Duncan Laurie, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49016
to look at the new patch set (#4).
Change subject: device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU ......................................................................
device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU
For onboard graphics initialization, GFX PEIM module inside FSP binary is taking care of graphics initialization based on HAVE_FSP_GOP Kconfig option and input VBT file. Hence no need to load/execute legacy VGA OpROM in order to initialize onboard GFX.
In case of non-FSP solution, platform need to select VGA_ROM_RUN Kconfig to perform graphics initialization for PCI-E based discrete card through VGA OpRom (SoC or Mainboard user can't select VGA_ROM_RUN directly because it's part of choice option).
Create VGA_ROM_RUN_DEFAULT Kconfig for mainboard to select design with DGPU where OpROM is embedded inside the DGPU card.
Also updated NO_GFX_INIT Kconfig to avoid running VGA_ROM_RUN by default in case SeaBIOS is used.
TEST=Able to get Pre-OS splash screen with PCI-E DGPU when mainboard user select VGA_ROM_RUN_DEFAULT.
Change-Id: Iecb2fcdb105af449bc20ad727759cdef17d5e376 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/Kconfig 1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/49016/4