Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32725 )
Change subject: Replace ENV_RAMSTAGE with ENV_PAYLOAD_LOADER
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32725/2/src/arch/x86/include/arch/acpi.h
File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/#/c/32725/2/src/arch/x86/include/arch/acpi.h@841
PS2, Line 841: #if ENV_PAYLOAD_LOADER && !defined(__SIMPLE_DEVICE__)
I agree. I've gotten confused as to coreboot practice around protos. […]
can you please review this CL: https://review.coreboot.org/#/c/coreboot/+/32764/
i have removed those unnecessary ENV_RAMSTAGE guards
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib54ece7b9e5f281f8a092dc6f38c07406edfa5fa
Gerrit-Change-Number: 32725
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 13 May 2019 08:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ron minnich
rminnich@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment