Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38781 )
Change subject: mb/lenovo: Remove thermal.h header ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/38781/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38781/1//COMMIT_MSG@10 PS1, Line 10: autoport
Can't say anything about this. Anyway should be made in a different patchset I believe.
Ack
https://review.coreboot.org/c/coreboot/+/38781/4/src/mainboard/lenovo/l520/a... File src/mainboard/lenovo/l520/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38781/4/src/mainboard/lenovo/l520/a... PS4, Line 26: which Sorry... *at* which
Also, could we please use C-style comments, as done in most other files for this platform?
https://review.coreboot.org/c/coreboot/+/38781/1/src/mainboard/lenovo/t430/a... File src/mainboard/lenovo/t430/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38781/1/src/mainboard/lenovo/t430/a... PS1, Line 28: gnvs->tmax = 105;
Honestly I've no idea why almost nobody is using it. […]
Ack