Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38016 )
Change subject: Documentation/superio: add generic PNP device documentation ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38016/4/Documentation/superio/commo... File Documentation/superio/common/pnp.md:
https://review.coreboot.org/c/coreboot/+/38016/4/Documentation/superio/commo... PS4, Line 3: super
Super
Done
https://review.coreboot.org/c/coreboot/+/38016/4/Documentation/superio/commo... PS4, Line 5: PNP devices are usually connected to the LPC bus of a system and shouldn't be confused with PCI(e) devices that use a completely different plug and play mechanism.
I wouldn’t break the line after each sentence, end also adhere to the line length limit.
Done. reflowed the text to 96 chars per line
https://review.coreboot.org/c/coreboot/+/38016/4/Documentation/superio/commo... PS4, Line 6: ISA plug and play specification
Add an URL?
URLs break from time to time; if the document had a document id, i'd have that added here, but it doesn't
https://review.coreboot.org/c/coreboot/+/38016/4/Documentation/superio/commo... PS4, Line 9: ## configuration access and config mode
Start headings with capital letter?
Done