Attention is currently required from: Paul Menzel, Yu-Ping Wu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59539 )
Change subject: drivers/analogix/anx7625: Fix return code handling
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i'd say that a function that returns a signed integer as status code is supposed to return a negativ […]
using enum cb_err as return value type of platform_i2c_transfer might be even better
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955b9aae11e20d75fac414d15714330e364dad2f
Gerrit-Change-Number: 59539
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Wei-Shun Chang
weishunc@google.com
Gerrit-Reviewer: Xin Ji
xji@analogix.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 24 Nov 2021 13:08:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment