Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )
Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 2: # Lock Down
Think I'll remove the comment, it is pretty self-explanatory anyways
Ack
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 5: .i2c[0] = {
/* I2C Touchpad */
Done
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 46: [PchSerialIoIndexI2C1] = PchSerialIoDisabled, : [PchSerialIoIndexI2C2] = PchSerialIoDisabled, : [PchSerialIoIndexI2C3] = PchSerialIoDisabled, : [PchSerialIoIndexI2C4] = PchSerialIoDisabled, : [PchSerialIoIndexI2C5] = PchSerialIoDisabled, : [PchSerialIoIndexSPI0] = PchSerialIoDisabled, : [PchSerialIoIndexSPI1] = PchSerialIoDisabled, : [PchSerialIoIndexSPI2] = PchSerialIoDisabled, : [PchSerialIoIndexUART0] = PchSerialIoDisabled, : [PchSerialIoIndexUART1] = PchSerialIoDisabled, :
drop the disabled ones; disabled is default anyways
Done
https://review.coreboot.org/c/coreboot/+/43623/9/src/mainboard/system76/lemp... PS9, Line 225: 15
This is 15 in hex, similar to the PCI devices. […]
Ack
https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43623/13/src/mainboard/system76/lem... PS13, Line 46: [PchSerialIoIndexUART2] = PchSerialIoSkipInit, // LPSS UART this is not explained and also still has nothing to do with the touchpad -> separate commit