Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43572 )
Change subject: zork/variants/dalboz: Use HS200 for eMMC
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43572/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/dalboz/variant.c:
https://review.coreboot.org/c/coreboot/+/43572/1/src/mainboard/google/zork/v...
PS1, Line 132: b/149941450
nit: Since the public can't see the bug, I wouldn't put it in the code. If there's anything in the bug that needs to be added, just add it in the comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43572
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e7a641bde04c5a7be29bf91c38dd8c110ed17a
Gerrit-Change-Number: 43572
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Peers
epeers@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jul 2020 15:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment