Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39340 )
Change subject: chromeos: remove get_write_protect_state function ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39340/3/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/39340/3/src/drivers/mrc_cache/mrc_c... PS3, Line 438: /* Read Write Protect GPIO if available */ : wp_gpio = get_write_protect_state();
We do see cases during dogfooding where SPI flash layout changes and so the entire SPI flash has to […]
Yeah this GPIO check was to make it easy to do a full RO update once booted without WP enabled.
I'm afraid option 2 could complicate RMA flows as well which are already painful for partners.
What about replacing the board-level WP GPIO checks with an OEM command to H1 to read the status directly? (same as crbug.com/1059675 but in firmware)