Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add family 15h ......................................................................
Patch Set 5:
(13 comments)
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG@7 PS5, Line 7: f
cap F. Also one below.
Will do.
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG@9 PS5, Line 9: Create documentation for AMD family 15h, and in particular to models for
Please make this statement jive with cpu/amd/family_10-family_16h, family15th (and Richland) and pi/ […]
jive? I don't understand. Sorry, English is not my first language.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 6: attend a broad spectrum
check your wording
I use spell checking... but I know it does not detects everything. Can you explain (English is not my first language)?
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 5: Family 15h is available in several models with different numbers of cores : and some other small variations,
This sounds like a marketing one-page. […]
True...but I have to start my document somewhere, and don't have much information to add here. What was new on family 15h (not available on family 14h)... or was it just a change in transistor size (Intel's TIC-TOC)?
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 7: micro architecture
one word
Thanks, will fix.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 9: use separate
maybe "use a separate"
Thanks, will fix.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 12: , which all [Family 17h](family17h.md) : will also use.
I would leave Family 17h and future tense "will use" out of this document.
Ok. Though I'm calling attention as to why I only added references to 2 models.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 19: PSP
It feels really out of place to read about the PSP here! Why is it needed for an introduction to Fa […]
Reading back, I agree. Will remove.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 29: the binary PI release
The reader doesn't yet know what a binaryPI release is.
Meaning I should explain it before this section?
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 29: coreboo
sp
Oops....
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 34: >In particular,
Why blockquote here? Also, I'm not sure that discussing coreboot's GPIO library adds much to the Fa […]
Block quote due to problems with formatting the way I want... though now I learned a different way that might solve the problem here. I just wanted to give an example of what and why was migrated from AGESA to coreboot.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 43: Control
Controller
Thanks.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 45: References
Models 00h-0Fh […]
I was intent on only the models used on recent coreboot code.