Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45418 )
Change subject: sc7180: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45418/1/src/soc/qualcomm/sc7180/soc... File src/soc/qualcomm/sc7180/soc.c:
https://review.coreboot.org/c/coreboot/+/45418/1/src/soc/qualcomm/sc7180/soc... PS1, Line 18: reserved_ram_resource(dev, 3, (uintptr_t)_dram_modem / KiB, Please respond on the bug as for why this is needed. This will permanently remove 140MB from the OS' available memory, even on systems without a modem. Having the kernel handle this internally so it can decide whether it has a modem or not (and reclaim the memory otherwise) would be much preferable. If that's really not possible, could we maybe at least condition this on sku_id() so we only remove the memory when really needed? (This would require us to keep track of an exact mapping which SKU numbers of which boards have a modem in firmware, which is a hassle I'd rather avoid... but still better than wasting so much memory.)