Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35891 )
Change subject: src/southbridge/amd/pi/hudson/sata.c: set SATA in AHCI mode ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35891/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35891/1//COMMIT_MSG@10 PS1, Line 10: Changing SATA mode from IDE to AHCI solved that issue.
Shouldn’t pfSense be able to deal with IDE mode?
Of course it deals with IDE mode, however, the pfSense software seems not to be robust. See: https://github.com/pcengines/apu2-documentation/blob/master/docs/debug/pfsen...
https://review.coreboot.org/c/coreboot/+/35891/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/sata.c:
https://review.coreboot.org/c/coreboot/+/35891/1/src/southbridge/amd/pi/huds... PS1, Line 51: /* enable AHCI mode */
Can you look at other boards, on how to make this build or run time configurable?
Firstly, we do not use CMOS runtime configuration for this board.
Secondly, there is CONFIG_HUDSON_SATA_MODE which is supposed to set the desired mode in AGESA blob, however, our experiments showed it doesn't work.