Attention is currently required from: Tim Wawrzynczak, Angel Pons, Andrey Petrov, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50916 )
Change subject: soc/intel/apollolake: Add `GPE0_STS_BIT` macro
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I wanted to write this:
How about defining a SMI_STS_SCI_MASK instead? i.e.
different masks for different platforms. If we have
to add fake definitions to the individual soc dirs,
I take it as a sign that we're doing it wrong.
However, I just remembered that the PM1_STS_BIT is
also documented as reserved and that seems wrong.
Especially before potentially misleading comments
are added, please test if the documentation matches
the hardware.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50916
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4408e016ba29cf8f7b125c95bfa668136b9eb93
Gerrit-Change-Number: 50916
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Feb 2021 16:28:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment