Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37135 )
Change subject: Enable and fix compiler warnings ......................................................................
Patch Set 10: Code-Review+1
(2 comments)
https://review.coreboot.org/c/em100/+/37135/10/hexdump.c File hexdump.c:
https://review.coreboot.org/c/em100/+/37135/10/hexdump.c@35 PS10, Line 35: int j This could also be a size_t
https://review.coreboot.org/c/em100/+/37135/10/spi.c File spi.c:
https://review.coreboot.org/c/em100/+/37135/10/spi.c@82 PS10, Line 82: int read_spi_flash_page(struct em100 *em100, int addr, unsigned char *blk) This no longer matches the declaration in em100.h
int read_spi_flash_page(struct em100 *em100, int address, unsigned char *blk);
Yes, it took me a while to find the definition for that declaration.