Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46304 )
Change subject: include/device/device.h: Move resource debug macros
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig@918
PS4, Line 918: # Only visible if DEBUG_SPEW (8) is set. It does additional printk(BIOS_DEBUG, ...) calls.
: config HAVE_DEBUG_RESOURCES
: def_bool n
This was based on a comment from Angel about reproduceable builds. […]
Ack
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig@922
PS4, Line 922: config DEBUG_RESOURCES
It seemed like these were useful and could be used generally. […]
Ack
https://review.coreboot.org/c/coreboot/+/46304/4/src/Kconfig@927
PS4, Line 927: This option enables additional PCI memory and IO debug messages.
:
: Note: This option will increase the size of the coreboot image.
:
: If unsure, say N
It is the same formatting used for all these debug options.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bdab7770ca5ee5901f17a8af3a9a1001b6702e4
Gerrit-Change-Number: 46304
Gerrit-PatchSet: 5
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 26 Oct 2020 03:10:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment