Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30822 )
Change subject: sb/intel/i82801gx: Detect if the southbridge supports AHCI ......................................................................
Patch Set 9:
(6 comments)
https://review.coreboot.org/#/c/30822/8/src/southbridge/intel/i82801gx/ide.c File src/southbridge/intel/i82801gx/ide.c:
https://review.coreboot.org/#/c/30822/8/src/southbridge/intel/i82801gx/ide.c... PS8, Line 22: #include "chip.h"
...
Done
https://review.coreboot.org/#/c/30822/8/src/southbridge/intel/i82801gx/sata.... File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/#/c/30822/8/src/southbridge/intel/i82801gx/sata.... PS8, Line 53: static int ahci_supported = -1;
Some idea: Update `config->sata_mode` instead. That would save some […]
Done
https://review.coreboot.org/#/c/30822/8/src/southbridge/intel/i82801gx/sata.... PS8, Line 58: pcidev_path_on_root
or: […]
Done
https://review.coreboot.org/#/c/30822/8/src/southbridge/intel/i82801gx/sata.... PS8, Line 160: ahci_bar[3] = config->sata_ports_implemented;
break here?
Done
https://review.coreboot.org/#/c/30822/9/src/southbridge/intel/i82801gx/sata.... File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/#/c/30822/9/src/southbridge/intel/i82801gx/sata.... PS9, Line 54: struct southbridge_intel_i82801gx_config *config = dev->chip_info; The whole part to check for AHCI support needs only be run `if (config->sata_mode == SATA_MODE_AHCI)`.
https://review.coreboot.org/#/c/30822/9/src/southbridge/intel/i82801gx/sata.... PS9, Line 63: return;
is it correct that pci_write_config8(dev, SATA_MAP, pci_read_config8(dev, SATA_MAP) & ~0xc3) doesn't […]
I guess it should be
config->sata_mode = SATA_MODE_IDE_PLAIN; } else { /* check ahci_supported */