Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37807 )
Change subject: util/lint: Provide some exemption to common parts of a vendor's MB
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b...
File util/lint/lint-stable-005-board-status:
https://review.coreboot.org/c/coreboot/+/37807/2/util/lint/lint-stable-005-b...
PS2, Line 20: if [[ ${mobodir} =~ ^src/mainboard/.*/common$ ]]; then
: continue
: fi
Done. The suggested regex is better than the original one. […]
Lint check still seems to fail for mb/intel/common CLs, can I keep the Kconfig.name and board_info.txt for now? and remove once we have this CL merged?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37807
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55c3474c17eacd008fee5f4089da33d4f7d6002a
Gerrit-Change-Number: 37807
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Dec 2019 04:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment