Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )
Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp...
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp...
PS4, Line 206: GPIO_WAKE_STATUS
Don't we reconfigure pins on S3 resume? Don't we want the wake status so that wake source reporting works correctly?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4ebd975312a4136f1d0690d7af7372615e31f0f
Gerrit-Change-Number: 42877
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 29 Jun 2020 22:40:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment