[coreboot-gerrit] Change in coreboot[master]: CBMEM: cbmem_initialize() in romstage is always _empty()

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Furquan Shaikh, Philipp Hug, Patrick Rudolph, Christian Walter, Julius Werner, Aaron Durbin, ron minnich.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50967 )

Change subject: CBMEM: cbmem_initialize() in romstage is always _empty()
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> I agree with the direction of this patch series, but as it changes API semantics, let's give it anot […]

CB:50987 is related.

Not under review yet, but I will suggest to replace romstage_handoff with a compulsory chipset_power_state initialised early in romstage, for platforms with ACPI S3 support.

Also, I don't see much value in having the separation of CBMEM hooks per stage, we can achieve the same with use of 'if (ENV_xx)' or better use of the is_recovery -parameter.