Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/20913 )
Change subject: mb/lenovo/x200: Add ACPI methods to set battery thresholds
......................................................................
Patch Set 3:
Why don't you use existing interface to make coreboot compatible with tpacpi-bat and thinkpad_acpi? They use the following ACPI methods:
* BCCS
* BCSS
* BICS
* BDSS
* PSSS
They allow to set thresholds, inhibit charge, peak shift, ...
--
To view, visit
https://review.coreboot.org/20913
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia049407cea7a60887ecba7b7c96e5000473865dd
Gerrit-Change-Number: 20913
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 09 Aug 2017 07:11:55 +0000
Gerrit-HasComments: No