Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32188 )
Change subject: WIP: Power resource stub
......................................................................
Patch Set 2:
Patch Set 2:
(21 comments)
This CL should be broken down into multiple smaller CLs:
- Adding probed property to sconfig to support probed devices
- Adding power resource device to device tree
- Adding power resource driver for ACPI
- Adding helper function for enabling power in bootblock
- Moving all mainboards using power resource to the newly added device
- Get rid of power resource properties from I2C generic and SPI devices.
- Get rid of probed property
If power is enabled in bootblock, and probing is done in ramstage, when is the appropriate time to deassert reset?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I253a11e24a086792e151c3e47335586d43c3fce0
Gerrit-Change-Number: 32188
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Apr 2019 03:10:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment