EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48446 )
Change subject: mb/google/brya: Add memory DQ map
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48446/1/src/mainboard/google/brya/v...
File src/mainboard/google/brya/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/48446/1/src/mainboard/google/brya/v...
PS1, Line 7: lpddr4x_cfg
these mappings look correct to me
Tim, would you like to raise the issue for this? I'm fine with both way. I'll change to adlrvp way for our bring up, then we can change back if Intel ready for it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94102240b13d2b95e0295f41bc2c0ba078faf242
Gerrit-Change-Number: 48446
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Dec 2020 03:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment