Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41988 )
Change subject: chromeos/cr50_enable_update.c: Modify recovery flow for cr50
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41988/2/src/vendorcode/google/chrom...
File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/c/coreboot/+/41988/2/src/vendorcode/google/chrom...
PS2, Line 77: * spooled by recovery_reason := VB2_RECOVERY_TRAIN_AND_REBOOT.
nit: This still doesn't really explain why it's checking for FORCE_RECOVERY. How about […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41988
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba341a750cce8334da4dcf6353ca8cd1268d170f
Gerrit-Change-Number: 41988
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 03 Jun 2020 14:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment