Attention is currently required from: Bao Zheng.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48955 )
Change subject: WIP:src/amd/common: Detect SOC type before access SPI 0x2C
......................................................................
Patch Set 37:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/48955/comment/896e316b_c9919fe8
PS37, Line 63: CONFIG(SOC_AMD_CEZANNE)
This certainly works, but as we add more chips, we'll need to keep updating it. What about checking the family of the chip and only enabling it if the chip is fam17h or earlier?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id493597b3854296a285d2337b7cf9fd01394d169
Gerrit-Change-Number: 48955
Gerrit-PatchSet: 37
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Comment-Date: Mon, 25 Jan 2021 20:59:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment