Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )
Change subject: mb/google/kukui: Initialize display ......................................................................
Patch Set 33:
(8 comments)
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel.h:
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 33: .cmd = INIT_DCS_CMD, \
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 34: .len = sizeof((u8[]){__VA_ARGS__}), \
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 35: .data = {__VA_ARGS__} }
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 38: .cmd = INIT_GENERIC_CMD, \
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 39: .len = sizeof((u8[]){__VA_ARGS__}), \
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 40: .data = {__VA_ARGS__} }
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 43: .cmd = DELAY_CMD,\
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/32511/33/src/mainboard/google/kukui... PS33, Line 44: .len = delay, }
code indent should use tabs where possible
Done