Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43175 )
Change subject: mb/google/dedede/var/boten: Update devicetree ......................................................................
Patch Set 5:
(2 comments)
Hi Peichao,
We will need your support to review the CL and have +1 first. Thanks.
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... PS5, Line 47: register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Integrated Bluetooth As comments in previous runs, some definition like usb2_ports[0-3|7] are already in baseboard/devicetree.cb so you don't need to re-specify here. Only the variant should be specified here.
https://review.coreboot.org/c/coreboot/+/43175/5/src/mainboard/google/dedede... PS5, Line 54: register "usb3_ports[5]" = "USB3_PORT_EMPTY" # Not Used Same as here and others.