Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich.
Joel Bueno has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/86588?usp=email )
Change subject: soc/riscv/ucb: Switch to FDT parsing to get memory size ......................................................................
Patch Set 3:
(7 comments)
File src/soc/ucb/riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/86588/comment/4daecd71_ee7ed928?usp... : PS2, Line 12: uint64_t top;
`please, no spaces at the start of a line` […]
Done
https://review.coreboot.org/c/coreboot/+/86588/comment/2d24240f_faeea746?usp... : PS2, Line 12: uint64_t top;
`code indent should use tabs where possible` […]
Done
https://review.coreboot.org/c/coreboot/+/86588/comment/7fd83007_424b71a9?usp... : PS2, Line 14: top = fdt_get_memory_top((void *)HLS()->fdt);
`code indent should use tabs where possible` […]
Done
https://review.coreboot.org/c/coreboot/+/86588/comment/046b2353_19a030a3?usp... : PS2, Line 15: ASSERT_MSG(top, "Failed reading memory range from FDT");
`code indent should use tabs where possible` […]
Done
https://review.coreboot.org/c/coreboot/+/86588/comment/2db60afc_58c56ee9?usp... : PS2, Line 15: ASSERT_MSG(top, "Failed reading memory range from FDT");
`please, no spaces at the start of a line` […]
Done
https://review.coreboot.org/c/coreboot/+/86588/comment/f3488adc_48924c82?usp... : PS2, Line 17: return MIN(top, (uint64_t)4 * GiB - 1);
`code indent should use tabs where possible` […]
Done
https://review.coreboot.org/c/coreboot/+/86588/comment/e27c5669_ff297897?usp... : PS2, Line 17: return MIN(top, (uint64_t)4 * GiB - 1);
`please, no spaces at the start of a line` […]
Done