Attention is currently required from: Eric Lai, Ivy Jian, Karthik Ramasubramanian, Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79101?usp=email )
Change subject: mb/google/brox: Set TPM i2c config in device tree ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79101/comment/c88caf24_9027de57 : PS1, Line 88: .i2c[0] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 650, : .fall_time_ns = 400, : .data_hold_time_ns = 50, : }, : .i2c[1] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 650, : .fall_time_ns = 400, : .data_hold_time_ns = 50, : }, : .i2c[2] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 900, : .fall_time_ns = 400, : .data_hold_time_ns = 50, : }, : .i2c[3] = { : .early_init = 1, : .speed = I2C_SPEED_FAST, : .rise_time_ns = 600, : .fall_time_ns = 400, : .data_hold_time_ns = 50, : }, : .i2c[5] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 650, : .fall_time_ns = 400, : .data_hold_time_ns = 50, : }, :
Hey Nick, in the past we could set these with through tuning with the help of a hw engineer. […]
Ok, I talked to Nick offline and he said to reorder the configs to match the order of the devices listed in the comments.
File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79101/comment/d53fadea_6d38419e : PS4, Line 107: .early_init = 1,
Now that GSC is in I2C4, this should be for i2c[4].
Done
https://review.coreboot.org/c/coreboot/+/79101/comment/83f84158_c43901bb : PS4, Line 169: device ref i2c3 on end
Can be removed, not that nothing is in I2C3.
Done