V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 )
Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller ......................................................................
Patch Set 3:
(1 comment)
Patch Set 2:
Patch Set 2:
@Arthur/Patrick R: Do you care to take -1 back?
So you somehow need to manually sync this Kconfig option with the devicetree in which the eMMC controller gets disabled too? If so my -1 stays here. If you somehow really don't want this ACPI code to be included when the device is disabled, generate it on runtime like told before or put it in a different file and don't include DSDT but yet another Kconfig option does not seem like a good solution.
@Arthur, Aligning with the approach that you suggested here i will be making the following changes,
SOC: Split the scs.asl into two different files (Sdcard and eMMC). Mainboard:
* Create a storage.asl for every variant and include the ASL files for storage they support. * Include the storage.asl in the mainboard dsdt.asl file. Any thoughts on the above mentioned changes or i will push this changes?
https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/Kconfig@216 PS2, Line 216:
a newline to much.
Done