21 Jan
2019
21 Jan
'19
9:47 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30749 )
Change subject: sb/amd/agesa/hudson/Kconfig: Disable XHCI by default, enable only with firmware ......................................................................
Patch Set 4:
I diffed KaveriPI xHCI source (that actually refers to bolton) against (scrubbed) TrinityPI xHCI source we have under vendorcode. Just by judging the number of added register modifications on bolton side, I do not expect bolton hardware to work reliably with vendorcode/fam15tn/.
In my opinion even the xHCI firmware loader in TrinityPI, for Hudson, seems fishy
--
To view, visit https://review.coreboot.org/c/coreboot/+/30749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f2b88d65f4f300ba1a28db09fb41d6bac6252b6
Gerrit-Change-Number: 30749
Gerrit-PatchSet: 4
Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com
Gerrit-Comment-Date: Mon, 21 Jan 2019 12:47:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment