Attention is currently required from: Nico Huber, Julius Werner.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70116 )
Change subject: commonlib/bsd, libpayload: Do not include helpers.h in stddef.h
......................................................................
Patch Set 3:
(1 comment)
File payloads/libpayload/arch/x86/boot_media.c:
https://review.coreboot.org/c/coreboot/+/70116/comment/420421f4_c7cec157
PS2, Line 6: #include <commonlib/bsd/helpers.h>
Should probably just include <libpayload.h> here which is what most libpayload code does.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia71edbc3ffe6694ff4b971decf3a41f915264bc8
Gerrit-Change-Number: 70116
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 16 Jan 2023 13:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment