Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47956 )
Change subject: fw_config: Default to undefined fw_config value ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47956/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47956/2//COMMIT_MSG@9 PS2, Line 9: If for some reason a value for fw_config cannot be located What use case is this change trying to target? Is it the case where fw_config is unprovisioned?
https://review.coreboot.org/c/coreboot/+/47956/2//COMMIT_MSG@12 PS2, Line 12: fw_config_probe_nodefault Under what circumstances would you use this function instead of fw_config_probe?
https://review.coreboot.org/c/coreboot/+/47956/2/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/47956/2/src/Kconfig@406 PS2, Line 406: When probing devices with fw_config, when the value is undefined or : unable to be located, all devices will be successfully probed, and : fw_config_probe will always return true. Do we really need a Kconfig for this? I think it should be the default behavior i.e. if FW_CONFIG is not provisioned, keep everything on by default. This should apply to all Chrome OS devices. I think we can add a Kconfig later if any non-Chrome OS devices using FW_CONFIG want to treat the unprovisioned case differently.