[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801dx: Drop APM_CNT_GNVS_UPDATE

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42425 )

Change subject: sb/intel/i82801dx: Drop APM_CNT_GNVS_UPDATE
......................................................................

sb/intel/i82801dx: Drop APM_CNT_GNVS_UPDATE

In commit 96cb252 the accompanying implementation
of smm_setup_structures() was already dropped.

Change-Id: I9cff0cbaa85cf771cc7761b6c5286ec34a76ee9a
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42425
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/southbridge/intel/i82801dx/smihandler.c
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c
index 9f9f2f3..b526a1a 100644
--- a/src/southbridge/intel/i82801dx/smihandler.c
+++ b/src/southbridge/intel/i82801dx/smihandler.c
@@ -25,7 +25,6 @@
  * initialize it with a sane value
  */
 u16 pmbase = PMBASE_ADDR;
-u8 smm_initialized = 0;

unsigned char *mbi = NULL;
 u32 mbi_len;
@@ -362,17 +361,6 @@
    	outl(pmctrl, pmbase + PM1_CNT);
    	printk(BIOS_DEBUG, "SMI#: ACPI enabled.\n");
    	break;
-	case APM_CNT_GNVS_UPDATE:
-		if (smm_initialized) {
-			printk(BIOS_DEBUG, "SMI#: SMM structures already initialized!\n");
-			return;
-		}
-		gnvs = *(global_nvs_t **)0x500;
-		tcg  = *(void **)0x504;
-		smi1 = *(void **)0x508;
-		smm_initialized = 1;
-		printk(BIOS_DEBUG, "SMI#: Setting up structures to %p, %p, %p\n", gnvs, tcg, smi1);
-		break;
    case APM_CNT_MBI_UPDATE: // FIXME
    	if (mbi_initialized) {
    		printk(BIOS_DEBUG, "SMI#: mbi already registered!\n");