Attention is currently required from: Matt DeVillier, Angel Pons, Lean Sheng Tan.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69202 )
Change subject: lib/ramtest.c: Update ram failure post code
......................................................................
Patch Set 1:
(1 comment)
File src/lib/ramtest.c:
https://review.coreboot.org/c/coreboot/+/69202/comment/1f1c2e53_f42bb27c
PS1, Line 203: POST_RAM_FAILURE
Yes, we should use `die_with_post_code()`
Sure, someone else can do that in a follow on patch. This patch isn't about fixing die() - that should come later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69202
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21ef196e48ff37ffe320b575d6de66b43997e7eb
Gerrit-Change-Number: 69202
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Fri, 11 Nov 2022 15:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment