build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36072 )
Change subject: mainboards: add GIGABYTE P34G v2 ......................................................................
Patch Set 2:
(22 comments)
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... File src/mainboard/gigabyte/p34g-v2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 13: /* 00 */ 0x0a, 0xe3, 0x5b, 0xa0, 0x80, 0x40, 0x60, 0x00, 0x00, 0x01, 0x00, 0x00, 0x80, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 14: /* 10 */ 0x54, 0x10, 0xa7, 0x0c, 0xdb, 0x0b, 0x2c, 0x42, 0xa2, 0x01, 0x65, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 15: /* 20 */ 0x60, 0x3b, 0x00, 0x00, 0x9a, 0x0b, 0x01, 0x01, 0x00, 0x00, 0x55, 0x34, 0x4e, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 16: /* 30 */ 0x47, 0x42, 0x54, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 17: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x55, 0x34, 0x4e, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 18: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0xa7, 0x0c, 0x54, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 19: /* 60 */ 0x3a, 0x37, 0x3a, 0x03, 0x00, 0x00, 0x15, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x0b, 0xdb, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 20: /* 70 */ 0x00, 0x65, 0x00, 0x00, 0x0c, 0xa7, 0x00, 0x00, 0x0b, 0x9a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x14, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 21: /* 80 */ 0x01, 0x44, 0x02, 0x87, 0x03, 0xcb, 0x05, 0x0f, 0x06, 0x53, 0x0c, 0x05, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 22: /* 90 */ 0x98, 0x00, 0x00, 0x15, 0x00, 0x00, 0x00, 0x15, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 23: /* a0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 24: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 25: /* c0 */ 0x00, 0x44, 0x00, 0x08, 0x00, 0x10, 0x00, 0x20, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 26: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 27: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 28: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 33: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... File src/mainboard/gigabyte/p34g-v2/romstage.c:
https://review.coreboot.org/c/coreboot/+/36072/2/src/mainboard/gigabyte/p34g... PS2, Line 48: void mainboard_romstage_entry() Bad function definition - void mainboard_romstage_entry() should probably be void mainboard_romstage_entry(void)
https://review.coreboot.org/c/coreboot/+/36072/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/36072/2/src/southbridge/intel/lynxp... PS2, Line 973: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36072/2/src/southbridge/intel/lynxp... PS2, Line 973: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36072/2/src/southbridge/intel/lynxp... PS2, Line 974: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36072/2/src/southbridge/intel/lynxp... PS2, Line 974: } please, no spaces at the start of a line