EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32519 )
Change subject: mb/google/sarien: Turn off camera power when s0ix ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/32519/4/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32519/4/src/mainboard/google/sarien/variants... PS4, Line 21: Printf ("OS Enter S0ix") : /* Turn on camera power */ : _SB.PCI0.STXS (GPP_B11)
Enter S0ix will turn off camera power and exit from s0ix will turn on camera power right?
oh yes, that's typo
https://review.coreboot.org/#/c/32519/4/src/soc/intel/cannonlake/acpi/lpit.a... File src/soc/intel/cannonlake/acpi/lpit.asl:
https://review.coreboot.org/#/c/32519/4/src/soc/intel/cannonlake/acpi/lpit.a... PS4, Line 67: If (CondRefOf (_SB.MS0X)) { : _SB.MS0X(1) : }
Add a comment to describe that's the s0ix hooks at motherboard level, or make the MS0X looks more cl […]
I don't know it proper to use EC interface, I think it's PCH behavior. And this project may need do other things like this... for the power consumption issue