[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Override weak functions for ioapic_id.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46327 )

Change subject: soc/amd/picasso: Override weak functions for ioapic_id.
......................................................................

Patch Set 1:

(2 comments)

Can’t this be done all in Kconfig?

https://review.coreboot.org/c/coreboot/+/46327/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46327/1//COMMIT_MSG@11 
PS1, Line 11: CONFIG_PICASSO_GNB_IOAPIC_ID.
Why are other values needed?

https://review.coreboot.org/c/coreboot/+/46327/1/src/soc/amd/common/block/sm... 
File src/soc/amd/common/block/smbus/sm.c:

https://review.coreboot.org/c/coreboot/+/46327/1/src/soc/amd/common/block/sm... 
PS1, Line 20: 	setup_ioapic(VIO_APIC_VADDR, soc_get_fch_ioapic_id());
Shouldn’t this go into the other commit?