Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42068 )
Change subject: soc/amd/picasso: Add device operations for UART MMIO devices
......................................................................
Patch Set 2:
this breaks the build for Mandolin with serial on LPC debug card enabled, since CONFIG_PICASSO_UART isn't set there resulting in a missing symbol error
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18abbe88952e7006668657eb1d0c177e53e95850
Gerrit-Change-Number: 42068
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 06 Jun 2020 20:29:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment