Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40525 )
Change subject: soc/mediatek/mt8183: Use term settings for high DRAM frequency ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40525/8/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/40525/8/src/soc/mediatek/mt8183/dra... PS8, Line 1222: clrsetbits32
Can you add a comment before this line? […]
the whole function of dramc_setting_DDR1600() and dramc_setting_DDR2400() and dramc_setting_DDR3600 are overwrite default 3200Mbps setting. that is default value set as 3200Mbsp, then if calibration other frequency, only change the difference setting between 3200. the 3600 diff with 3200 only selph_dqs0 and selph_dqs1, so at function of dramc_setting_DDR3600, only have those 2 settings.