Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34178 )
Change subject: soc/intel/cannonlake: Make EC S0ix notification optional in LPIT
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34178/3/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/lpit.asl:
PS3:
Not for this change, but I think we should eventually move this file to soc/intel/common since there is nothing cannonlake specific in it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf465f8ad7cb016f3ad3d9710b46e35f66f8939b
Gerrit-Change-Number: 34178
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evan Green
evgreen@chromium.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Comment-Date: Tue, 09 Jul 2019 20:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment